Implement autodetection for default compiler from NDK #495
Conversation
Dushistov
force-pushed
the
fix-build-with-new-ndk
branch
from
724afc7 to
110e038
Compare
Dushistov
force-pushed
the
fix-build-with-new-ndk
branch
from
110e038 to
8c40bad
Compare
| .replace("armv7neon", "arm") | ||
| .replace("armv7", "arm") | ||
| .replace("thumbv7neon", "arm") | ||
| .replace("thumbv7", "arm"); |
There was a problem hiding this comment.
FWIW this normalization isn't used when trying to find a new compiler, could this be refactored a bit such that these rustc targets would still find the armv7a android compiler?
There was a problem hiding this comment.
I intentionally did not touch this code. Tier 1,2 platforms have only linux+android support. So it is hard test for Windows and MacOS, but code bellow works with windows, so I avoid changing anything that I can not test.
Plus I don't think that this is refactoring is possible. IMHO new target naming that include android API level was introduced recently, so if somebody do not want update Android NDK and uses old clang it is easy enough to break things for them.
There was a problem hiding this comment.
My point is that the armv7-linux-androideabi target, if folks are using it, will not hit the new clang compiler when it very likely should. I don't think there's a lot of risk here, it's basically just moving this let target block up to the top of the function instead of having it at the bottom
There was a problem hiding this comment.
My point is that the armv7-linux-androideabi target, if folks are using it, will not hit the new
clang compiler when it very likely should.
@alexcrichton, not sure that I understand you. armv7-linux-androideabi mapped to Some("armv7a") and then to armv7a-linux-androideabi16-clang call.
So armv7-linux-androideabi hit the new clang compiler, it is my main testing configuration,
I built all my code with cargo build --target=armv7-linux-androideabi and ran on android device before submitting this PR.
There was a problem hiding this comment.
Ah ok I think I was misreading a bit. In any case we can always tweak this later!
Dushistov
force-pushed
the
fix-build-with-new-ndk
branch
from
8c40bad to
af713db
Compare
Dushistov
force-pushed
the
fix-build-with-new-ndk
branch
from
af713db to
f952e20
Compare
|
Thanks again! |
ref #459
Long time ago you had to extract compiler from Android NDK to make it standalone and usable as linker/c/c++ compiler (for example process described here https://mozilla.github.io/firefox-browser-architecture/experiments/2017-09-21-rust-on-android.html).
At now you can use default C/C++ compiler without efforts. But naming for compilers are different now. For example before this patch, cc-rs try to find
arm-linux-androideabi-clang, but default compiler now isarmv7a-linux-androideabi16-clang. Also new clang compiler doesn't define things likeANDROID/__ANDROID_API__so it should be defined manually.Without this patch I can not compile rusqlite for android:
it prints: